Disable flaky FE tests

[KaiserKarel]

No description provided.

[KaiserKarel]

Task linked: CU-8676y2c83 Disable flaky UI tests

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
pablo-nightly	✅ Ready (Inspect)	Visit Preview	Dec 16, 2022 at 8:55PM (UTC)
picasso-nightly	❌ Failed (Inspect)		Dec 16, 2022 at 8:55PM (UTC)

[github-actions]

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/fe3eaad61745910e758c3b930a88fbea102d7d07 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/fe3eaad61745910e758c3b930a88fbea102d7d07#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/fe3eaad61745910e758c3b930a88fbea102d7d07#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/fe3eaad61745910e758c3b930a88fbea102d7d07#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/fe3eaad61745910e758c3b930a88fbea102d7d07#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

[github-actions]

Visit the preview URL for this PR (updated for commit fe3eaad):

https://composable-docs--false-bvmz1swb.web.app

_{(expires Fri, 23 Dec 2022 21:14:57 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 9f02f9c6590528fd01c58c1497c91fed08e5194c}

[dzmitry-lahoda]

@KaiserKarel may be better https://jestjs.io/docs/cli#--testpathignorepatternsregexarray and no modification of target code a lot?

Via CLI can easy wire #flaky or flaky in CI to try run (by using cli params). With config file modification approach will need to patch file. Seem CLI easier for temporal off changes.

CI """owner""" should be able to disable without interfering a lot with coders imho.

[github-actions]

Visit the preview URL for this PR (updated for commit fe3eaad):

https://picasso-f0d16--pr2743-disable-flaky-ui-tes-7aiax6vg.web.app

_{(expires Fri, 23 Dec 2022 21:26:24 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: d4e030ec330173845b1768cd217beee9791d20f1}

[github-actions]

Visit the preview URL for this PR (updated for commit fe3eaad):

https://pablo-afa5d--pr2743-disable-flaky-ui-tes-1uj94jd7.web.app

_{(expires Fri, 23 Dec 2022 21:26:39 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 8ef316967fc7aa470dc109d617260c43c009e4e3}

[KaiserKarel]

@KaiserKarel may be better https://jestjs.io/docs/cli#--testpathignorepatternsregexarray and no modification of target code a lot?

Via CLI can easy wire #flaky or flaky in CI to try run (by using cli params). With config file modification approach will need to patch file. Seem CLI easier for temporal off changes.

CI """owner""" should be able to disable without interfering a lot with coders imho.

I can move the ignore to CI too; but would prefer to enable strict testing of FE asap, because right now more bad tests are getting into the codebase.

[dzmitry-lahoda]

please add tests to effects gate. because it is very annoying to see failed red CI jobs and wait until all jobs need to retry one failed. so at least there will be urge to fix tests and we can ask for that.

because also you disabled some flaky, but who knows if all. so we would be in same situation after pr merged, unless it is effects gate.

so either we disable and allow to enable using label/tag or if enabled by default - put into gate.
no gated red fails are 100% ignored.

[KaiserKarel]

please add tests to effects gate. because it is very annoying to see failed red CI jobs and wait until all jobs need to retry one failed. so at least there will be urge to fix tests and we can ask for that.

because also you disabled some flaky, but who knows if all. so we would be in same situation after pr merged, unless it is effects gate.

so either we disable and allow to enable using label/tag or if enabled by default - put into gate. no gated red fails are 100% ignored.

👍

We'll be prioritizing fixing these tests after release 3, so only expect them to be disabled until the 22nd.