Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PoolConfig fetch #2748

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Add PoolConfig fetch #2748

merged 8 commits into from
Dec 21, 2022

Conversation

easteregg
Copy link
Contributor

No description provided.

@KaiserKarel
Copy link
Contributor

Task linked: CU-33a8nq4 Integration - FE integration with latest pablo dex interfaces

@github-actions
Copy link

github-actions bot commented Dec 18, 2022 •
edited

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/7dd52a52eba9d5589da1edd48104436265cdd887 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/7dd52a52eba9d5589da1edd48104436265cdd887#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/7dd52a52eba9d5589da1edd48104436265cdd887#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/7dd52a52eba9d5589da1edd48104436265cdd887#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/7dd52a52eba9d5589da1edd48104436265cdd887#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@github-actions
Copy link

github-actions bot commented Dec 18, 2022 •
edited

Visit the preview URL for this PR (updated for commit 99d4871):

https://composable-docs--false-bvmz1swb.web.app

(expires Wed, 28 Dec 2022 13:37:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9f02f9c6590528fd01c58c1497c91fed08e5194c

@github-actions
Copy link

Picasso preview URL: https://picasso-production-aw9h3q2fz-composable-finance.vercel.app

@itsbobbyzz
Copy link

Task linked: CU-865bb3r7e Add PoolConfig fetch

@github-actions
Copy link

Picasso preview URL: https://picasso-production-16nymbe1k-composable-finance.vercel.app

@easteregg
SimulateAddLiquidity
7dd52a5 
Update Pool and Subscription

Update Pool amount

Update non-compliant data-types to pass the build

AddLiquidity happy path
@easteregg easteregg force-pushed the Integration---FE-integration-with-latest-pablo-dex-interfaces-(CU-33a8nq4) branch from 8d11d22 to 7dd52a5 Compare December 19, 2022 17:37
@github-actions
Copy link

Picasso preview URL: https://picasso-production-jc5zwe08e-composable-finance.vercel.app

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/db355974a88091eab80482dc8d68c90d1cfcc867 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/db355974a88091eab80482dc8d68c90d1cfcc867#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/db355974a88091eab80482dc8d68c90d1cfcc867#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/db355974a88091eab80482dc8d68c90d1cfcc867#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/db355974a88091eab80482dc8d68c90d1cfcc867#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@github-actions
Copy link

github-actions bot commented Dec 20, 2022 •
edited

Picasso preview URL: https://picasso-production-7ll9djf7s-composable-finance.vercel.app

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/5c1b3c7c25583eca474bf25e4e3a15a989ce4404 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/5c1b3c7c25583eca474bf25e4e3a15a989ce4404#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/5c1b3c7c25583eca474bf25e4e3a15a989ce4404#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/5c1b3c7c25583eca474bf25e4e3a15a989ce4404#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/5c1b3c7c25583eca474bf25e4e3a15a989ce4404#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@easteregg easteregg force-pushed the Integration---FE-integration-with-latest-pablo-dex-interfaces-(CU-33a8nq4) branch from 5c1b3c7 to 470f4e4 Compare December 20, 2022 09:21
@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/470f4e40905489b94a986e1b5c4ab0a1733686b3 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/470f4e40905489b94a986e1b5c4ab0a1733686b3#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/470f4e40905489b94a986e1b5c4ab0a1733686b3#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/470f4e40905489b94a986e1b5c4ab0a1733686b3#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/470f4e40905489b94a986e1b5c4ab0a1733686b3#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/4485b8a40160fc2191b060b6a70208a2c12987ea --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/4485b8a40160fc2191b060b6a70208a2c12987ea#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/4485b8a40160fc2191b060b6a70208a2c12987ea#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/4485b8a40160fc2191b060b6a70208a2c12987ea#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/4485b8a40160fc2191b060b6a70208a2c12987ea#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@github-actions
Copy link

github-actions bot commented Dec 20, 2022 •
edited

Pablo preview URL: https://pablo-production-bs2cmoyez-composable-finance.vercel.app

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/1cbfc2d5a49abd03bb385eb087d22d9ac2170725 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/1cbfc2d5a49abd03bb385eb087d22d9ac2170725#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/1cbfc2d5a49abd03bb385eb087d22d9ac2170725#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/1cbfc2d5a49abd03bb385eb087d22d9ac2170725#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/1cbfc2d5a49abd03bb385eb087d22d9ac2170725#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@github-actions
Copy link

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/99d4871c34b9bb6c244ec516e92c825cd3f79d89 --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/99d4871c34b9bb6c244ec516e92c825cd3f79d89#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/99d4871c34b9bb6c244ec516e92c825cd3f79d89#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/99d4871c34b9bb6c244ec516e92c825cd3f79d89#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/99d4871c34b9bb6c244ec516e92c825cd3f79d89#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@easteregg easteregg marked this pull request as ready for review December 20, 2022 14:41
@easteregg easteregg requested review from a team as code owners December 20, 2022 14:41
andyjsbell
andyjsbell approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking this as too large to review effectively, will be deprecated at some point and QA have agreed to qualify it. Thanks @easteregg

LyonSsS
LyonSsS previously approved these changes Dec 21, 2022
View reviewed changes
Copy link

@LyonSsS LyonSsS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - to be validate be QA without 100% code review cover.
Validated by @andyjsbell also

@LyonSsS LyonSsS dismissed their stale review December 21, 2022 11:06

no QA validation on code

@KaiserKarel KaiserKarel merged commit 50aeb66 into main Dec 21, 2022
@KaiserKarel KaiserKarel deleted the Integration---FE-integration-with-latest-pablo-dex-interfaces-(CU-33a8nq4) branch December 21, 2022 15:05
benluelo pushed a commit that referenced this pull request Dec 21, 2022
@easteregg @benluelo
Add PoolConfig fetch (#2748)
4bef0fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresmechali andresmechali andresmechali approved these changes

@andyjsbell andyjsbell andyjsbell approved these changes

@LyonSsS LyonSsS LyonSsS left review comments

@vimukthi-git vimukthi-git Awaiting requested review from vimukthi-git vimukthi-git was automatically assigned from ComposableFi/parachain-finance

@obsessed-cake obsessed-cake Awaiting requested review from obsessed-cake obsessed-cake was automatically assigned from ComposableFi/parachain-finance

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@easteregg @KaiserKarel @itsbobbyzz @andresmechali @LyonSsS @andyjsbell