-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users can add liquidity to the pools without respecting the existing ratio in the pools (cu 86694adqg) #2767
Conversation
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/df5e18c068c274b1bd04b75441fb0615df921518#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/df5e18c068c274b1bd04b75441fb0615df921518#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/df5e18c068c274b1bd04b75441fb0615df921518#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/df5e18c068c274b1bd04b75441fb0615df921518#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Visit the preview URL for this PR (updated for commit 6cbbe6e): https://composable-docs--false-bvmz1swb.web.app (expires Thu, 29 Dec 2022 10:12:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9f02f9c6590528fd01c58c1497c91fed08e5194c |
Pablo preview URL: https://pablo-production-njm6lqjnb-composable-finance.vercel.app |
Picasso preview URL: https://picasso-production-9g4horza2-composable-finance.vercel.app |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/19f82515e552da8a0aab3b933f598b0a111bd219#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/19f82515e552da8a0aab3b933f598b0a111bd219#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/19f82515e552da8a0aab3b933f598b0a111bd219#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/19f82515e552da8a0aab3b933f598b0a111bd219#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments for clarity
} | ||
} | ||
|
||
pub fn normalize_asset_deposit_infos_to_min_ratio<AssetId: Copy>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a comment on the algo used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a simple doc comment, not sure what else to add
code/parachain/frame/pablo/src/test/dual_asset_constant_product_tests_new.rs
Show resolved
Hide resolved
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/6e62554d18c5af80f36e302f6956e11b1d21f61c#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/6e62554d18c5af80f36e302f6956e11b1d21f61c#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/6e62554d18c5af80f36e302f6956e11b1d21f61c#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/6e62554d18c5af80f36e302f6956e11b1d21f61c#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
btw let's name branches with some short simple name like clickup issue number eg: |
This was the clickup suggested branch name, as per @KaiserKarel |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/84ec290c04bf81a291cbbb71802fd417fa9a3b66#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/84ec290c04bf81a291cbbb71802fd417fa9a3b66#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/84ec290c04bf81a291cbbb71802fd417fa9a3b66#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/84ec290c04bf81a291cbbb71802fd417fa9a3b66#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
@@ -424,7 +426,7 @@ pub fn normalize_asset_deposit_infos_to_min_ratio<AssetId: Copy>( | |||
.ok_or(AssetDepositNormalizationError::ArithmeticOverflow)?; | |||
} | |||
|
|||
Ok(adis) | |||
Ok(dbg!(asset_deposit_infos)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need debug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/090f7d15e04323412180df067299bc58063057e5#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/090f7d15e04323412180df067299bc58063057e5#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/090f7d15e04323412180df067299bc58063057e5#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/090f7d15e04323412180df067299bc58063057e5#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/b3ff09d70e9b1367ee94b29f7e00e1d235856c05#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/b3ff09d70e9b1367ee94b29f7e00e1d235856c05#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/b3ff09d70e9b1367ee94b29f7e00e1d235856c05#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/b3ff09d70e9b1367ee94b29f7e00e1d235856c05#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/281f9b5fd05c113f39020f464fd501c110e8d953#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/281f9b5fd05c113f39020f464fd501c110e8d953#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/281f9b5fd05c113f39020f464fd501c110e8d953#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/281f9b5fd05c113f39020f464fd501c110e8d953#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/31b7305efcc784ea3b352c1d6175e56d9d700dab#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/31b7305efcc784ea3b352c1d6175e56d9d700dab#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/31b7305efcc784ea3b352c1d6175e56d9d700dab#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/31b7305efcc784ea3b352c1d6175e56d9d700dab#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Nix commands for this PRNOTE: You can also run our Nix commands in Docker. See the bottom of this comment. Make sure you have setup the Composable community cache:(you only need to run it once on your machine) nix-shell -p cachix --command "cachix use composable-community" Show all possible apps, shells and packages:
Run the Composable node alone:nix run "github:ComposableFi/composable/6cbbe6e04bfa16b50e721172a347de40cac0c467#composable-node" -L Spin up a local devnet:nix run "github:ComposableFi/composable/6cbbe6e04bfa16b50e721172a347de40cac0c467#devnet" -L --option sandbox relaxed --show-trace Spin up a local XCVM devnet:nix run "github:ComposableFi/composable/6cbbe6e04bfa16b50e721172a347de40cac0c467#devnet-xcvm" -L View the docs:nix run ".#docs-server" Run this without Nix in Docker.docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/6cbbe6e04bfa16b50e721172a347de40cac0c467#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes" NOTE: You can swap |
Also fixes https://app.clickup.com/t/861m406gb