Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds simnode for testing parachain runtime upgrades. #409

Merged
merged 15 commits into from Jan 10, 2022
Merged

adds simnode for testing parachain runtime upgrades. #409

merged 15 commits into from Jan 10, 2022

Conversation

seunlanlege
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@0253cea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage        ?   60.43%           
=======================================
  Files           ?      141           
  Lines           ?    20350           
  Branches        ?        0           
=======================================
  Hits            ?    12298           
  Misses          ?     8052           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0253cea...80c5635. Read the comment docs.

KaiserKarel
KaiserKarel previously approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please remove the wasm artifact, no need to commit that, although it does not affect the releaser.

haroldsphinx
haroldsphinx previously approved these changes Jan 9, 2022
View reviewed changes
@seunlanlege seunlanlege merged commit a532ead into main Jan 10, 2022
@seunlanlege seunlanlege deleted the seun-simnode branch January 10, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzmitry-lahoda dzmitry-lahoda dzmitry-lahoda left review comments

@haroldsphinx haroldsphinx haroldsphinx approved these changes

@KaiserKarel KaiserKarel KaiserKarel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seunlanlege @codecov-commenter @dzmitry-lahoda @haroldsphinx @KaiserKarel