Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using Vec<> in CurveAmm/Uniswap pallet storage. #430

Merged
merged 1 commit into from Jan 7, 2022
Merged

Stop using Vec<> in CurveAmm/Uniswap pallet storage. #430

merged 1 commit into from Jan 7, 2022

Conversation

vivekvpandya
Copy link
Contributor

No description provided.

@vivekvpandya vivekvpandya self-assigned this Dec 28, 2021
andor0
andor0 reviewed Dec 28, 2021
View reviewed changes
frame/curve-amm/src/lib.rs Outdated Show resolved Hide resolved
dzmitry-lahoda
dzmitry-lahoda approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it not stack allocates, but heap. so can improve still.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@bd55fe0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage        ?   60.36%           
=======================================
  Files           ?      144           
  Lines           ?    20523           
  Branches        ?        0           
=======================================
  Hits            ?    12389           
  Misses          ?     8134           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd55fe0...06a183a. Read the comment docs.

@KaiserKarel KaiserKarel merged commit ac4177e into main Jan 7, 2022
@KaiserKarel KaiserKarel deleted the uniswap_main branch January 7, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzmitry-lahoda dzmitry-lahoda dzmitry-lahoda approved these changes

@KaiserKarel KaiserKarel KaiserKarel approved these changes

@hussein-aitlahcen hussein-aitlahcen Awaiting requested review from hussein-aitlahcen

@andor0 andor0 Awaiting requested review from andor0

@benluelo benluelo Awaiting requested review from benluelo

Assignees

@vivekvpandya vivekvpandya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vivekvpandya @codecov-commenter @dzmitry-lahoda @andor0 @KaiserKarel