CU-1wty1y5 weights for dutch auction #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzmitry-lahoda
commented
Dec 29, 2021
•
dzmitry-lahoda
commented
- bench test pass, but not yet part of runtime (will do it in next pr)
- fixed some security holes
- added comment about attempts to refactor currency system
|
Task linked: CU-1wty1y5 auction: weights |
dzmitry-lahoda
requested review from
andor0,
hussein-aitlahcen and
vivekvpandya
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
from
43649ea
to
ad3b85d
Compare
vivekvpandya
reviewed
Jan 3, 2022
vivekvpandya
reviewed
Jan 3, 2022
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
from
86565d5
to
fd2686d
Compare
KaiserKarel
reviewed
Jan 3, 2022
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
from
fd2686d
to
fd19855
Compare
hussein-aitlahcen
previously approved these changes
Jan 4, 2022
|
Heh, clippy PR merged, need rebase |
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
from
213cc91
to
0ccab3c
Compare
hussein-aitlahcen
previously approved these changes
Jan 5, 2022
KaiserKarel
previously approved these changes
Jan 5, 2022
|
@dzmitry-lahoda seems to me it is all signed? |
dzmitry-lahoda
dismissed stale reviews from KaiserKarel and hussein-aitlahcen
via
4a85928
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
2 times, most recently
from
4a85928
to
b450da8
Compare
Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
dzmitry-lahoda
force-pushed
the
dz/weghts-42
branch
from
b450da8
to
066226f
Compare
hussein-aitlahcen
approved these changes
Jan 5, 2022
vivekvpandya
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.