Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-1m98wce lending docs and fixes #441

Merged
merged 8 commits into from Jan 6, 2022
Merged

CU-1m98wce lending docs and fixes #441

merged 8 commits into from Jan 6, 2022

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Jan 3, 2022

  • https://app.clickup.com/20465559/v/dc/kghwq-20761/kghwq-3701
  • fixed double exponent bug (it was not double and was a ladder, not smooth)
  • comment issue with PID (cannot get stable PID with reasonable parameters and UT = Optimal UT with some initial borrow rate, it always goes infinity up - bug, not yet fixed)
  • refactoring lending
  • all models except double exponent work as before

@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft January 3, 2022 22:40
@dzmitry-lahoda dzmitry-lahoda changed the title Dz/interests CU-1m98wce lending docs and fixes Jan 4, 2022
@itsbobbyzz
Copy link

Task linked: CU-1m98wce Angular interest documentation

vivekvpandya
vivekvpandya previously approved these changes Jan 4, 2022
Copy link
Contributor

@vivekvpandya vivekvpandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hussein-aitlahcen
Copy link
Contributor

Good for me, need rebase

Signed-off-by: Dzmitry Lahoda <dzmitry@lahoda.pro>
@KaiserKarel KaiserKarel merged commit cdbdd0f into main Jan 6, 2022
@KaiserKarel KaiserKarel deleted the dz/interests branch January 6, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants