New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-1m98wce lending docs and fixes #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dzmitry-lahoda
commented
Jan 3, 2022
•
edited
edited
- https://app.clickup.com/20465559/v/dc/kghwq-20761/kghwq-3701
- fixed double exponent bug (it was not double and was a ladder, not smooth)
- comment issue with PID (cannot get stable PID with reasonable parameters and UT = Optimal UT with some initial borrow rate, it always goes infinity up - bug, not yet fixed)
- refactoring lending
- all models except double exponent work as before
dzmitry-lahoda
force-pushed
the
dz/interests
branch
from
January 4, 2022 07:29
8b40c99
to
1e82327
Compare
Task linked: CU-1m98wce Angular interest documentation |
dzmitry-lahoda
force-pushed
the
dz/interests
branch
2 times, most recently
from
January 4, 2022 07:41
254cf32
to
4c64773
Compare
dzmitry-lahoda
requested review from
hussein-aitlahcen,
andor0 and
vivekvpandya
January 4, 2022 07:42
dzmitry-lahoda
force-pushed
the
dz/interests
branch
from
January 4, 2022 08:11
4c64773
to
8fde610
Compare
vivekvpandya
reviewed
Jan 4, 2022
vivekvpandya
reviewed
Jan 4, 2022
vivekvpandya
reviewed
Jan 4, 2022
vivekvpandya
previously approved these changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Good for me, need rebase |
dzmitry-lahoda
force-pushed
the
dz/interests
branch
2 times, most recently
from
January 5, 2022 15:24
87fa7ce
to
b96ecaa
Compare
dzmitry-lahoda
force-pushed
the
dz/interests
branch
from
January 5, 2022 15:28
4775454
to
bd54991
Compare
vivekvpandya
approved these changes
Jan 6, 2022
KaiserKarel
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.