Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/simnode workflow #461

Merged
merged 42 commits into from Jan 10, 2022
Merged

Feature/simnode workflow #461

merged 42 commits into from Jan 10, 2022

Conversation

haroldsphinx
Copy link
Contributor

  • Add backup script to CI
  • Add workflow step to check simonode test

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@a532ead). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage        ?   60.44%           
=======================================
  Files           ?      141           
  Lines           ?    20350           
  Branches        ?        0           
=======================================
  Hits            ?    12300           
  Misses          ?     8050           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a532ead...8b0514e. Read the comment docs.

Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add cargo to the path, as well as removing actions-rs

Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing offline, we decided to add the feedback in a later PR

@nimboya nimboya self-requested a review January 10, 2022 12:37
@seunlanlege seunlanlege merged commit 526263a into main Jan 10, 2022
@seunlanlege seunlanlege deleted the feature/simnode-workflow branch January 10, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants