Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added runtime integration tests #473

Merged
merged 3 commits into from Jan 12, 2022
Merged

Added runtime integration tests #473

merged 3 commits into from Jan 12, 2022

Conversation

Dominique-Roth
Copy link
Contributor

Added runtime integration tests. Original repository: https://github.com/Dom-Roth/picasso-integration-tester

KaiserKarel
KaiserKarel previously approved these changes Jan 11, 2022
Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Obviously a large amount of todo's in there, but already quite a large PR. I suggest trimming some stuff, and then fixing the todo's and nice-to-haves in a subsequent PR

Copy link
Contributor

@hussein-aitlahcen hussein-aitlahcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this so that we can collaborate on the same repo from now on. I'll push a PR to refactor + fix crowdloan tests as well as abstract some stuff to make it easier for newcomers.

@KaiserKarel KaiserKarel merged commit 845a4d4 into ComposableFi:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants