CU-1tf7kpr - Picasso v0 runtime - part 1 #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Tokens` should never be used, except for `Assets` dependency The `Assets` pallet is acting as a router forwarding PICA operations to `Balance` and any other token operation to `Tokens`. By using `Tokens` instead of `Assets`, the pallet will not be able to operate on PICA.
|
Task linked: CU-1tf7kpr Picasso V0 runtime ugprade |
dzmitry-lahoda
previously approved these changes
Jan 12, 2022
hussein-aitlahcen
force-pushed
the
picasso-v0-runtime
branch
from
3f13311
to
0cb27ba
Compare
seunlanlege
reviewed
Jan 12, 2022
hussein-aitlahcen
force-pushed
the
picasso-v0-runtime
branch
from
0cb27ba
to
b0ca667
Compare
hussein-aitlahcen
force-pushed
the
picasso-v0-runtime
branch
from
b0ca667
to
f336612
Compare
dzmitry-lahoda
approved these changes
Jan 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 60.49% 60.75% +0.25%
==========================================
Files 141 141
Lines 20309 20312 +3
==========================================
+ Hits 12286 12340 +54
+ Misses 8023 7972 -51
Continue to review full report at Codecov.
|
KaiserKarel
approved these changes
Jan 12, 2022
|
Discussed offline to merge this, to allow for collaborations. |
KaiserKarel
added a commit
that referenced
this pull request
Jan 12, 2022
This reverts commit be98233.
seunlanlege
reviewed
Jan 13, 2022
Comment on lines
+816
to
+820
| Factory: currency_factory::{Pallet, Storage, Event<T>} = 53, | ||
| GovernanceRegistry: governance_registry::{Pallet, Call, Storage, Event<T>} = 54, | ||
| Assets: assets::{Pallet, Call, Storage} = 55, | ||
| CrowdloanRewards: crowdloan_rewards::{Pallet, Call, Storage, Event<T>} = 56, | ||
| Vesting: vesting::{Call, Event<T>, Pallet, Storage} = 57, |
There was a problem hiding this comment.
@hussein-aitlahcen this pr doesn't add these pallets to the benchmark section
seunlanlege
reviewed
Jan 13, 2022
Comment on lines
+75
to
+80
| currency-factory = { package = "pallet-currency-factory", path = "../../frame/currency-factory", default-features = false } | ||
| governance-registry = { package = "pallet-governance-registry", path = "../../frame/governance-registry", default-features = false } | ||
| assets = { package = "pallet-assets", path = '../../frame/assets', default-features = false } | ||
| crowdloan-rewards = { package = "pallet-crowdloan-rewards", path = '../../frame/crowdloan-rewards', default-features = false } | ||
| vesting = { package = "pallet-vesting", path = "../../frame/vesting", default-features = false } | ||
| bonded-finance = { package = "pallet-bonded-finance", path = "../../frame/bonded-finance", default-features = false } |
There was a problem hiding this comment.
missing std features as well as runtime-benchmark features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce simple pallets for the V0.
I'll create a second, more specific one for Apollo.