Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to F#4.7 and netcore 3.0. #36

Merged
merged 4 commits into from Oct 15, 2019
Merged

Upgrade to F#4.7 and netcore 3.0. #36

merged 4 commits into from Oct 15, 2019

Conversation

@isaacabraham
Copy link
Member

isaacabraham commented Oct 13, 2019

Takes advantage of implicit yields in two ways:

  1. Removal of existing yield statements (yield! is expanded to for x in y do x - not sure about this).
  2. Removed use of collect with a for x in y do in Arm.fs. This was an unexpected "benefit" in that you remove collect completely as well as the use of [ ] syntax for each case.

Thoughts?

@isaacabraham isaacabraham requested a review from theprash Oct 13, 2019
@isaacabraham

This comment has been minimized.

Copy link
Member Author

isaacabraham commented Oct 13, 2019

@Dzoukr I can't add you as a reviewer for some reason but have a look at this anyway :-)

@Dzoukr

This comment has been minimized.

Copy link
Contributor

Dzoukr commented Oct 13, 2019

As I would consider .net core 3 & F# 4.7 as the "new default" so totally ok with me. 👍

Code changes looks good - personally need to take some time to get used to implicit yields, but it's my brain's problem. :)

@isaacabraham

This comment has been minimized.

Copy link
Member Author

isaacabraham commented Oct 13, 2019

Same here!

@isaacabraham isaacabraham merged commit e256c4f into master Oct 15, 2019
@isaacabraham isaacabraham deleted the netcore3 branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.