Upgrade to F#4.7 and netcore 3.0. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dzoukr I can't add you as a reviewer for some reason but have a look at this anyway :-) |
|
As I would consider .net core 3 & F# 4.7 as the "new default" so totally ok with me. 👍 Code changes looks good - personally need to take some time to get used to implicit yields, but it's my brain's problem. :) |
|
Same here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes advantage of implicit yields in two ways:
yieldstatements (yield!is expanded tofor x in y do x- not sure about this).collectwith afor x in y doinArm.fs. This was an unexpected "benefit" in that you removecollectcompletely as well as the use of[ ]syntax for each case.Thoughts?