-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmosdb serverless #845
Cosmosdb serverless #845
Conversation
The support for serverless capacity mode introduces a breaking change in CosmosDbBuilder.DbThroughput
c0eee8f
to
e0110ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. I think there's a couple of API surface suggestions that I would like to see that would make the API even more compelling, but the majority of this looks good to go.
type CapacityMode = | ProvisionedThroughput of int<RU> | Serverless
…d of 'capacityMode'
@isaacabraham is this ready to merge? |
Apologies, I need to review the updates. |
# Conflicts: # RELEASE_NOTES.md # src/Farmer/Arm/DocumentDb.fs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go. I made a few tiny tweaks:
- Removing a
when
to a proper pattern match (best practice - pattern matches give better guidance for missing cases). - Replaced Throughput with FeatureFlag on the Account (correctness - Account doesn't need to know about Throughput, just if Serverless is set or not).
- Renamed ProvisionedThroughput to simply Provisioned.
- Added an example in the docs.
@ninjarobot ok, this is good to go from my side. @amine-mejaouel if you would like to confirm that my final tweaks are ok with you, this can go in. Thanks again! |
It's all good to me, |
This PR closes #333
Thanks to discussion in #333 and for @dnperfors and @JordanMarr work on the subject, I added the last brick in order to make the serverless work on cosmos db.
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: