Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task failure criteria #269

Closed
wpbonelli opened this issue Jan 28, 2022 · 1 comment
Closed

Task failure criteria #269

wpbonelli opened this issue Jan 28, 2022 · 1 comment
Assignees
@wpbonelli
Labels
bug Something isn't working priority Should be resolved first, if possible python Pull requests that update Python code question Further information is requested

Comments

@wpbonelli
Copy link
Member

Currently a task is considered to have succeeded if the corresponding scheduler job runs to completion without timing or erroring out. This includes tasks which expect outputs but fail to produce them. This is misleading and confusing- if a job is expected to produce output files, we should mark it failed if it does not.

Are there any other similar cases to consider?
@wpbonelli wpbonelli added bug Something isn't working priority Should be resolved first, if possible python Pull requests that update Python code question Further information is requested labels Jan 28, 2022
@wpbonelli wpbonelli self-assigned this Jan 28, 2022
wpbonelli added a commit that referenced this issue Feb 7, 2022
@wpbonelli
better task status handling (#269)
60aab47
wpbonelli added a commit that referenced this issue Feb 7, 2022
@wpbonelli
#269 fixes and cleanup
4f7b502
@wpbonelli
Copy link
Member Author

Updated in 4f7b502

wpbonelli added a commit that referenced this issue Feb 11, 2022
@wpbonelli
handle failure to refresh CyVerse access tokens, more efficient task …
62b2f27 
…results checking, consider missed patterns to indicate task failure (update #269)
wpbonelli added a commit that referenced this issue Feb 11, 2022
@wpbonelli
debug #269 pattern handling, fix for last task config repopulation on…
02347ac 
… workflow view
wpbonelli added a commit that referenced this issue Feb 14, 2022
@wpbonelli
UI fixes, better task status naming, don't consider missing output pa…
85bafaa 
…tterns a failure (amend #269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wpbonelli wpbonelli

Labels
bug Something isn't working priority Should be resolved first, if possible python Pull requests that update Python code question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wpbonelli