Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian/Ubuntu Packages Close #70 #82

Merged
merged 5 commits into from
Apr 28, 2014

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Dec 20, 2013

I know it's a 1.2 feature, but do not slap me 'cause it's Christmas time - wohooooooo.

Features tested and working on make package:

  • works with mpich2 and openmpi
  • works with serial libSplash too and with/without TOOLS_MPI
  • supports -dbg packages
  • creates a meaningful package name (see e.g. hdf5 package names)
  • adds all relevant meta information to .deb files (dependencies, suggestions, ...)
  • is always a "dev" versions because it ships include headers too
  • .travis.yml cleaned up (global vars now on a central place) and installs the .deb package for example compiles (tests still compiled in-source)

Things to be done / reviewed:

  • Can I add your ZIH E-Mail address in the code? (Yeah, they got a good spam filter.)
  • Maybe we ship only parallel packages with releases (as additional download).
  • Have to check if I call the serial package libsplash-serial. Does the Debian flag enhances "upgrade and replace" that or just "add" to it ?.
  • I would postpone .rpm and OSX shipping (I didn't find a good doc for the first and the API is still changing to heavily for OSX and I have no testing env for it) - and of course NSIS Windows shipping can wait due to missing relevance for HPC (but there are, like in OSX, users that do their data analysis on it) ...
  • install splash2xdmf.py python module example, policy

@ghost ghost assigned f-schmitt Dec 20, 2013
@ax3l
Copy link
Member Author

ax3l commented Dec 20, 2013

This pull request is for review purposes, does not have to go in 1.1 (but could).

I just realized we could also try to use the static hdf5 libs for shipping (which did not work the last time by setting HDF5_USE_STATIC_LIBRARIES) and include all the weird dependencies from linking, too.

@f-schmitt
Copy link
Member

Nice work, let's keep this one open until after 1.1 since it should be very low merge/rebase overhead.

@ax3l
Copy link
Member Author

ax3l commented Dec 20, 2013

Sounds good. I could partially move out some of the .travis.yml improvements already. If I find the time I will send you a matching pull request and rebase this branch on it.

IF(HDF5_IS_PARALLEL OR TOOLS_MPI)
SET(MPI_FLAVOR "openmpi")
SET(MPI_FLAVOR_BIN "openmpi-bin")
SET(MPI_FLAVOR_MINVERSION 1.4.3)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to >= 1.5.1
http://svn.open-mpi.org/svn/ompi/branches/v1.5/NEWS

- Use memmove (instead of memcpy) when necessary (e.g., source and
  destination overlap).

@ax3l
Copy link
Member Author

ax3l commented Jan 9, 2014

Update: Rebased against latest changes

@f-schmitt
Copy link
Member

ok, this goes in 1.2

  - works with mpich2
  - works with serial libSplash and with/without TOOLS_MPI
  - supports -dbg packages
  - create a meaningful package name (see e.g. hdf5 package names)
  - adds all relevant meta information
  - is always a "dev" versions because it ships headers too
  - Travis: install by package manager
@ax3l
Copy link
Member Author

ax3l commented Apr 25, 2014

Rebased, updated with the last points, checked and ready for the merge :)


# create or creates specific library names like ???
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the ???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) will fix

f-schmitt pushed a commit that referenced this pull request Apr 28, 2014
Debian/Ubuntu Packages Close #70
@f-schmitt f-schmitt merged commit aa30770 into ComputationalRadiationPhysics:dev Apr 28, 2014
@ax3l ax3l deleted the topic/deb branch April 28, 2014 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants