Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename types.h to "pmacc_types.hpp` #1355

Closed
psychocoderHPC opened this issue Jan 27, 2016 · 6 comments
Closed

rename types.h to "pmacc_types.hpp` #1355

psychocoderHPC opened this issue Jan 27, 2016 · 6 comments
Assignees
Labels
component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API

Comments

@psychocoderHPC
Copy link
Member

Currently the global PMacc definitions are places in a C header files.
we should:

  • rename it to a C++ header (file ending .hpp)
  • change the name to pmacc_types to avoid conflicts with system headers
@psychocoderHPC psychocoderHPC added component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API labels Jan 27, 2016
@psychocoderHPC psychocoderHPC added this to the Future milestone Jan 27, 2016
@BenjaminW3
Copy link
Member

👍

@ax3l
Copy link
Member

ax3l commented Jan 27, 2016

yeees pls! :)

@ax3l ax3l modified the milestones: Open Beta, Future Jan 27, 2016
@bussmann
Copy link
Member

Noooo! Introduce more C header files and give them names of existing standard C header files!!!

@ax3l
Copy link
Member

ax3l commented Jan 28, 2016

Next step: try to get PRs merged upstream in glibc renaming those standard headers to "resolve conflicts" 🎸

@ax3l
Copy link
Member

ax3l commented Feb 5, 2016

@psychocoderHPC just a side note: we will not install libPMacc without a prefix directory, since this is messy and will always collide somewhere with third parties.

We can still rename the file, but users of PMacc should include it in a <pmacc/some_header.hpp> and <pmacc/pmacc_types.hpp> way.

Example install in --prefix=/usr (as seen in boost or libSplash):

# headers
/usr/include/pmacc/some_header.hpp
/usr/include/pmacc/memory/even_more_headers.hpp
# ...

Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 10, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 22, 2016
Flamefire pushed a commit to Flamefire/picongpu that referenced this issue Feb 22, 2016
@ax3l
Copy link
Member

ax3l commented Nov 2, 2016

closed with #1367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Development

No branches or pull requests

5 participants