You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would like to rename all parts in the ionization framework to enhance transparency and to avoid misunderstandings.
Therefore I would propose the following changes:
ionization.hpp --> ionization.kernel
After all the refactoring all that is left of the contents is the kernel. ionization/byField/ionizers.[def|hpp] --> ionization/byField/fieldIonizationModels.[def|hpp]
because these files just collect the .def and .hpp files of the models and thus are a list of the models AlgorithmADK[None/BSI/...].hpp --> ADK[BSI/none/...]Calc.hpp
All files belonging to a certain model should have names starting with the model name, right?
otherwise: CalcADK? CompADK? ADKComp[utation]?
Introduce a new file fieldIonizationCalc.hpp
containing all the includes for the calculation of the models, like e.g. ADKCalc.hpp
Do you think ionizerConfig.[param|unitless] can keep its name? Right now it just does forward declaration / collects includes but I am positive that we might soon get model-specific quantities that we will have to make unitless. (e.g. Keldysh parameter)
To do after changes: update the Wiki
Please feel free to suggest more suitable names if you can think of any.
The text was updated successfully, but these errors were encountered:
I already updated the regex' in your description to be valid. so generally, yes :D
starting the file name with the model groups the model-related files nicely together, that's good. Calculation and Computation is a bit too general, maybe we can find something more specific. If you want to denote the actual core if the implementation, @psychocoderHPC used the ...Impl.abc prefix in the last commits quite regular.
I would like to rename all parts in the ionization framework to enhance transparency and to avoid misunderstandings.
Therefore I would propose the following changes:
ionization.hpp
-->ionization.kernel
After all the refactoring all that is left of the contents is the kernel.
ionization/byField/ionizers.[def|hpp]
-->ionization/byField/fieldIonizationModels.[def|hpp]
because these files just collect the
.def
and.hpp
files of the models and thus are a list of the modelsAlgorithmADK[None/BSI/...].hpp
-->ADK[BSI/none/...]Calc.hpp
All files belonging to a certain model should have names starting with the model name, right?
otherwise:
CalcADK
?CompADK
?ADKComp[utation]
?Introduce a new file
fieldIonizationCalc.hpp
containing all the includes for the calculation of the models, like e.g.
ADKCalc.hpp
Do you think
ionizerConfig.[param|unitless]
can keep its name? Right now it just does forward declaration / collects includes but I am positive that we might soon get model-specific quantities that we will have to make unitless. (e.g. Keldysh parameter)Please feel free to suggest more suitable names if you can think of any.
The text was updated successfully, but these errors were encountered: