Laser Wavepacket: Implementation != Doc #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
|
looks good to me 👍 |
|
ah, same doc for all lasers to be explicit :) |
|
|
Follow-Up to ComputationalRadiationPhysics#1232: the implementation of the laser wavepacket regarding the *beam waist* does not fit its documentation in `laserConfig.param`. This commit updates the implementation to match the documentation which is then identical to the other laser pulses. Currently, the parameter that was specified is a factor `sqrt(2)` off making the pulse waist effectively *tighter* by this factor than intended.
Extends the wavepacket with additional information for conversion to typical quantities used in experiments.
ax3l
force-pushed
the
fix-laserWavePacket
branch
from
5050e27
to
8bfd4fa
Compare
|
@ax3l thx |
|
np, thx |
|
@PrometheusPi can we merge? :) (I already have the mail open for hours for the user list ;) ) |
PrometheusPi
added a commit
that referenced
this pull request
Dec 18, 2015
Laser Wavepacket: Implementation != Doc
|
there was a minus sign removed in |
|
awww. good catch! |
ax3l
commented
Dec 20, 2016
| @@ -113,7 +113,7 @@ HDINLINE float3_X laserTransversal(float3_X elong, const float_X, const float_X | |||
| const float_X exp_x = posX * posX / (W0_X * W0_X); | |||
| const float_X exp_z = posZ * posZ / (W0_Z * W0_Z); | |||
|
|
|||
| return elong * math::exp(float_X(-0.5) * (exp_x + exp_z)); | |||
| return elong * math::exp(exp_x + exp_z); | |||
There was a problem hiding this comment.
Gosh! Arrrrr! 🙈
math::exp(float_X(-1.0) * (exp_x + exp_z));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up to #1232: the implementation of the laser wavepacket regarding the beam waist does not fit its documentation in
laserConfig.param.This commit updates the implementation to match the documentation which is then identical to the other laser pulses. Currently, the parameter that was specified is a factor
sqrt(2)off making the pulse waist effectively tighter by this factor than intended.To Do