Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move RNG memory init before particle memory init #1547

Conversation

PrometheusPi
Copy link
Member

When allocating the RNG memory only 300 MB were free. Thus if the RNG needed a lot of memory (e.g. more than 250MB) no kernel could start. This is avoided by placing the RNG memory allocation before the particle memory allocation.

cc: @Heikman @Flamefire @ax3l

@ax3l This affects the latest release. Please back-port this bug fix.

When allocating the RNG memory only 300 MB were free. Thus if
the RNG needed a lot of memory (e.g. more than 250MB) no kernel
could start. This is avoided by placing the RNG memory allocation
before the particle memory allocation.
@PrometheusPi PrometheusPi added bug a bug in the project's code component: core in PIConGPU (core application) affects latest release a bug that affects the latest stable release labels Aug 9, 2016
@PrometheusPi PrometheusPi added this to the 0.2.0: Open Beta milestone Aug 9, 2016
@PrometheusPi
Copy link
Member Author

@psychocoderHPC I checked this fix without the fix of #1546 - the 250MB of memory are allocated but the simulation does not crash anymore.

@PrometheusPi
Copy link
Member Author

@n01r Then this affects your code as well.

@psychocoderHPC
Copy link
Member

Short description without magic numbers:

  • one rule in PIConGPU is that it is not allowed to allocate memory after the particles memory pool is created (memory pool allocates all free memory)
  • in the current devbranch the RNGProvider is created after the memory pool (not allowed)
    -> this can results in an out of memory error

Solution of this pull request: move the creation of the RNGProvider before the particle memory pool creation

@psychocoderHPC psychocoderHPC merged commit a2d0fa9 into ComputationalRadiationPhysics:dev Aug 10, 2016
@PrometheusPi PrometheusPi deleted the fix_memoryAllocationPositionRNG branch August 10, 2016 13:09
@psychocoderHPC psychocoderHPC mentioned this pull request Aug 12, 2016
4 tasks
@PrometheusPi PrometheusPi mentioned this pull request Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: core in PIConGPU (core application)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants