Fix energy density #1750
Merged
Fix energy density #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heikoburau
added
affects latest release
ax3l
force-pushed
the
fix-EnergyDensity
branch
from
a91ff30
to
fd4c126
Compare
ax3l
approved these changes
Jan 5, 2017
|
@psychocoderHPC that one is for you to finish. |
psychocoderHPC
approved these changes
Jan 6, 2017
ax3l
moved this from Applied to release-0.2.3
to Documented in Changelog
in 0.2.3 Backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix energy density calculation. Prior to this the weighting factor was wrongly included in the energy density expression resulting in a quadratic dependency.
Work-Around: Use
CreateEnergyOperationinstead and divide by cell volume.