remove CONST_VECTOR from OnePositionParameter #4875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change from old
CONST_VECTOR
for specifying the initial particle position in the template parameter for the OnePosition startPosition functor to the newconstexpr float3_X
compile time specification.This breaks old setups, trying to compile a setup using
CONST_VECTOR
will give the following error:... picongpu/include/picongpu/../picongpu/particles/startPosition/OnePositionImpl.hpp(45): error: a nonstatic member reference must be relative to a specific object constexpr auto initialPosition = T_ParamClass::inCellOffset;
To update a setup, replace in
particle.param
your definition of the OnePositionParam, something like the following,with an updated version along the lines of this