fix include guard Shadowgraphy plugin #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrometheusPi
added
bug
|
There seems to be more issues than just the include guard - I will have a look |
PrometheusPi
force-pushed
the
fix_include_guard_Shadowgraphy
branch
from
9b17b32
to
f82a140
Compare
|
Include guard were needed in two places. Is now fixed. |
|
Tested - works. |
This was referenced May 2, 2024
psychocoderHPC
approved these changes
May 6, 2024
psychocoderHPC
merged commit 37753c1
into
ComputationalRadiationPhysics:dev
9 checks passed
|
Well, it's too late to review now, I was struggling with some issues on my end until now (did not delete old files when rsyncing my local repo to dev server...). Yes this PR works |
psychocoderHPC
added
the
changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4897
This pull request fixes #4897 the missing openPMD-api include guard for the shadowgraphy plugin.