CI: test latest ISAAC #4903
Merged
CI: test latest ISAAC #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
psychocoderHPC
commented
May 8, 2024
psychocoderHPC
commented
- install glm 1.0.1 for ISAAC
- test latest ISAAC dev branch
- install glm 1.0.1 for ISAAC - test latest ISAAC dev branch
PrometheusPi
approved these changes
May 14, 2024
| @@ -19,7 +19,7 @@ if [ -z "$DISABLE_ISAAC" ] ; then | |||
| cd $CI_PROJECT_DIR | |||
| git clone https://github.com/ComputationalRadiationPhysics/isaac.git | |||
| cd isaac | |||
| git checkout 195420ca1c43f6148c7f6c3a10ad9cad32e04d6a | |||
| git checkout 6bf8e189142da7ab16f8367316fb21dcaa7e3b78 | |||
There was a problem hiding this comment.
@psychocoderHPC why do you specify a specific branch (the current head?)
There was a problem hiding this comment.
offline discussion with @psychocoderHPC: This avoids that the PIConGPU CI breaks because we accidentally introduce an error in ISAAC.
PrometheusPi
merged commit f3a169c
into
ComputationalRadiationPhysics:dev
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.