-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version of propose_changelog.py #4908
New version of propose_changelog.py #4908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a help (as used by all other tools) would be a nice to have.
As the CI does something weird currently and @psychocoderHPC will most likely be the main user of this, we'll wait for your approval for this. |
@chillenzer Can we automatically run a short regex over the output to remove |
Hi, I've gone the simple route of just removing all quotes. I would argue that the changelog will experience minor human adjustment anyways, so adding a single pair of missing quotes every few releases won't hurt that much. |
b202137
into
ComputationalRadiationPhysics:dev
As requested by @psychocoderHPC, here's a quick rewrite of
propose_changelog.py
. One matter of taste might be that I have chosen to depend onpyyaml
for the pretty printing of nested dictionaries. That is technically not necessary but I really don't care for writing all the formatting by hand. This comes with the tiny drawback that all the strings containing#
are surrounded by single quotes. Theoretically, the formatting can be adjusted arbitrarily by writing custom dumpers but then again, we would be back at writing custom formatting code.Output at the time of writing
Output