fix 2D zigzag z-flux calculation #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix wrong velocity for for z-flux calculation
psychocoderHPC
added
bug
|
Might be we should add this bug fix to the up coming PIConGPU version 0.1 |
|
current dev 2D KHI - positrons/electrons - drift in z direction |
|
backported to |
|
purely transverse KHI (positrons/electrons) since the initial flow of particles is in -/+z direction, the feedback loop and due to that growth rate was "roughly doubled" in this test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zigzag implementation split all particle trajectories for any direction in two independent trajectories.
The current implementation also need to does it for the z-direction in 2D, therefore the velocity must halved.
affects simulations only all of the following applies:
ZigZagsolver was used for charged species