Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Error Pages #200

Merged
merged 7 commits into from
Mar 9, 2020
Merged

Custom Error Pages #200

merged 7 commits into from
Mar 9, 2020

Conversation

devinmatte
Copy link
Member

Fixes #160

Adds error pages for 500 and 404 errors. Still sends errors to sentry.

This allows users to still have access to the toolbar so they can tab back to where they need to be easily

mxmeinhold
mxmeinhold approved these changes Mar 9, 2020
View reviewed changes
Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢 🙌

Only comment is this looks like it’s merging master into develop as well. I think that’s fine, but if you want to maintain the same pattern we’ve had I’d cherry pick or rebase onto develop.

@mxmeinhold mxmeinhold merged commit 96fbe3e into ComputerScienceHouse:develop Mar 9, 2020
@devinmatte devinmatte mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxmeinhold mxmeinhold mxmeinhold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Error Pages
2 participants
@devinmatte @mxmeinhold