Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints and mypy #257

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

mxmeinhold
Copy link
Collaborator

Add type hints to most functions, in an effort towards #177. Also added mypy and ci for it. Skipped routes, since I didn't want to wrangle the info dict just now.

packet/models.py Show resolved Hide resolved
Copy link
Member

@adamhb123 adamhb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxmeinhold
Copy link
Collaborator Author

Force pushing to squash fixups before merge

@mxmeinhold mxmeinhold merged commit 3a51db1 into ComputerScienceHouse:develop Apr 2, 2021
mxmeinhold added a commit that referenced this pull request Apr 2, 2021
@mxmeinhold
Copy link
Collaborator Author

So, I messed up the merge and undid it. This actually got squashed to 73e55ac and merged as 2c25b06.

@mxmeinhold mxmeinhold mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants