Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR to EBoard Tags #342

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

jabbate19
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabbate19
Copy link
Collaborator Author

No, it falls under the Eboard tag

@Mstrodl
Copy link
Member

Mstrodl commented Aug 23, 2022

Do you need to add a badge css? https://github.com/ComputerScienceHouse/packet/blob/develop/frontend/scss/components/badges.scss

No:

    &.badge-eboard {
        color: #fff;
        background-color: #4CAF50;
    }

@mxmeinhold
Copy link
Collaborator

Double checking a couple other things, since this was a while ago. Are you able to run a build on packet-dev, or do you want me to?

@jabbate19
Copy link
Collaborator Author

I haven't done it before and don't have access. Can you run it if you have time?

Copy link
Collaborator

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to develop, then let's figure out if doing a deploy or if we're trying to resolve the admin issues

@mxmeinhold mxmeinhold merged commit 55e2712 into ComputerScienceHouse:develop Aug 23, 2022
@mxmeinhold mxmeinhold mentioned this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants