Impose limits on all VM creation #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents people from trying to allocate more resources than they have available in total. This isn't the best solution, since it may prevent people from having many VMs with only a few started up, but that's a problem for when users start complaining.
|
Have you tested this against the method I described in the document |
|
I have not. I was lowkey hoping you could do that for me? 😅 Maybe you could show me how? |
|
The frontend still reports success to the user, so we gotta transport that 403 up to it somehow so that it displays an error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents people from trying to allocate more resources than they have available in total. This isn't the best solution, since it may prevent people from having many VMs with only a few started up, but that's a problem for when users start complaining.