Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile_wallet: Use conventional naming for transaction types #445

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bisgardo
Copy link
Contributor

@bisgardo bisgardo commented Sep 19, 2023

Purpose

The dApp lib @concordium/wallet-connectors was changed to use lower case transaction type in Concordium/concordium-dapp-libraries#42 to match the convention set by wallet-proxy and the internal types (iOS) of the mobile wallets.

This PR aligns the change with the crypto library to use the same type names.

Changes

Make the mobile wallet crypto library use the conventional type names (in camelCase).

Part of https://concordium.atlassian.net/browse/CBW-1360.

@abizjak
Copy link
Member

abizjak commented Sep 19, 2023

This change would mean that we are introducing an incompatibility that we need to deal with. Why are we doing this exactly?

It would mean that the new wallet only supports the camelcase format, and the old wallet supports the old format. What is a dapp going to do?

@bisgardo
Copy link
Contributor Author

This change would mean that we are introducing an incompatibility that we need to deal with. Why are we doing this exactly?

The wallets are currently not calling the lib with the correct type names. It's not introducing an incompatibility, it's part of fixing the currently incompatibility.

The problems are not the same on iOS and Android and it's of course part of the task to ensure that both work.

It would mean that the new wallet only supports the camelcase format, and the old wallet supports the old format.

The dapp payload doesn't/shouldn't go here directly. It gets parsed into the internal type that I linked in the description (iOS). It's the internal type that gets converted into the payload for this lib.

What is a dapp going to do?

Use the new type names. The special case "Update" will be supported for backwards comp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants