Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply standard #84

Merged
merged 9 commits into from
May 1, 2024
Merged

Apply standard #84

merged 9 commits into from
May 1, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Apr 25, 2024 •
edited

Purpose

closes #82

Related to:
Concordium/concordium-update-proposals#62

Changes

Smart contract changes:

  • Add initial_status in the create event.
  • Use the TokenIdU64 type as an alias for itemID.
  • Add supports function (CIS-0).

Front-end changes:

  • Display initial_status from the create event.
  • Propagate smart contract changes.

Indexer/Server changes:

  • Propagate smart contract changes.

@DOBEN DOBEN force-pushed the apply-CIS6-standard-at-track-and-trace branch from e991dd4 to 3ac81a6 Compare April 26, 2024 10:32
@DOBEN DOBEN force-pushed the apply-CIS6-standard-at-track-and-trace branch from 3ac81a6 to 4ab5713 Compare April 26, 2024 10:35
soerenbf
soerenbf reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to run through a test run but here are a few things so far:

trackAndTrace/frontend/src/components/Explorer.tsx Outdated Show resolved Hide resolved
trackAndTrace/frontend/src/components/Explorer.tsx Outdated Show resolved Hide resolved
trackAndTrace/frontend/src/components/AdminCreateItem.tsx Outdated Show resolved Hide resolved
trackAndTrace/test-scripts/src/main.rs Outdated Show resolved Hide resolved
trackAndTrace/test-scripts/src/main.rs Outdated Show resolved Hide resolved
trackAndTrace/test-scripts/src/main.rs Outdated Show resolved Hide resolved
@DOBEN DOBEN requested a review from soerenbf April 29, 2024 12:22
@DOBEN DOBEN force-pushed the apply-CIS6-standard-at-track-and-trace branch from 8eedcfd to 7128ece Compare April 30, 2024 09:06
@DOBEN DOBEN requested a review from soerenbf April 30, 2024 12:49
soerenbf
soerenbf approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

trackAndTrace/smart-contract/src/lib.rs Show resolved Hide resolved
@DOBEN DOBEN merged commit 172733f into main May 1, 2024
57 checks passed
@DOBEN DOBEN deleted the apply-CIS6-standard-at-track-and-trace branch May 1, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenbf soerenbf soerenbf approved these changes

@Bargsteen Bargsteen Bargsteen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track-and-trace standard (CIS6)
3 participants
@DOBEN @soerenbf @Bargsteen