Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the tests in the wallet-test-bench for signing of binary messages in the mobile wallets #145

Merged
merged 6 commits into from Apr 24, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Apr 22, 2024

Purpose

Related to:
Concordium/concordium-dapp-libraries#70
Concordium/concordium-dapp-libraries#43

  • Add the WALLET_CONNECT_SCOPE which excludes the RequestVerifiablePresentation method compared to the default FULL_WALLET_CONNECT_NAMESPACE_CONFIG. The method is not supported by legacy wallets. To continue testing legacy wallets with this front-end it is excluded.

Changes

  • Enable the tests for signing of byte messages in the mobile wallets.
  • Update dependency to the dapp-libraries.
  • Update @concordium/web-sdk dependency to version 7.0.0 to work with the above dapp-libraries.
  • Define WALLET_CONNECT_SCOPE to test current and legacy wallets.
  • Fix eslint command.

@DOBEN DOBEN force-pushed the enable-signing-of-binary-messages branch from 0f81348 to c4517de Compare April 22, 2024 17:17
@DOBEN DOBEN changed the title Add signing of binary messages in mobile wallets Add tests for signing of binary messages in mobile wallets Apr 22, 2024
@DOBEN DOBEN changed the title Add tests for signing of binary messages in mobile wallets Add tests to the wallet-test-bench for signing of binary messages in mobile wallets Apr 23, 2024
@DOBEN DOBEN changed the title Add tests to the wallet-test-bench for signing of binary messages in mobile wallets Enable the tests in the wallet-test-bench for signing of binary messages in the mobile wallets Apr 23, 2024
@DOBEN DOBEN force-pushed the enable-signing-of-binary-messages branch from b721791 to e2f8b15 Compare April 23, 2024 18:17
Copy link
Contributor

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

wallet-connect-test-bench/front-end/package.json Outdated Show resolved Hide resolved
wallet-connect-test-bench/front-end/package.json Outdated Show resolved Hide resolved
@DOBEN DOBEN force-pushed the enable-signing-of-binary-messages branch from e7020d9 to dab36b5 Compare April 24, 2024 10:14
@DOBEN DOBEN merged commit f0bf40a into main Apr 24, 2024
18 checks passed
@DOBEN DOBEN deleted the enable-signing-of-binary-messages branch April 24, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants