Delegation #35
Merged
Delegation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shjortConcordium
approved these changes
Mar 16, 2022
shjortConcordium
approved these changes
Mar 16, 2022
3 tasks
soerenbf
pushed a commit
that referenced
this pull request
May 29, 2024
…sages (#35) Replaced the string message type in signMessage with a new type SignableMessage which is a discriminated union of a binary message (which has a type/parameter schema) and a simple string message. The mobile wallets don't yet support signing binary messages, so the WalletConnect implementation throws an exception for that case. It's very non-desirable to throw exceptions at use time for unimplemented features as compared to enabling the dApp to detect available features for a given connection. But in this case, the warts that this would impose on the interface are not deemed worth it: The MW aren't lacking the feature, it's more like they aren't entirely done implementing it... The sample dApp sign-message is updated to support both variants by adding a "schema" input for the parameter schema (represented as base64). If this input is non-empty, the message is assumed to be binary (represented as hex). Otherwise it's a plain string. Also, renamed ParameterSchema to TypeSchema to make it more semantically correct to use this in the context of message values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update SDK to provide necessary functionality to support delegation features.
Should probably tag npm publish with alpha
npm publish --tag alphaChanges
Checklist
hard-to-understand areas.