WalletConnect: Implement request handling #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dium/concordium-reference-wallet-ios into feature/wc-further-implementation
- Reuse generic approval view for request approval view. - Delete redundant view controllers (i.e. when UIHostingController suffices). - Unwrap closures that invoke a single no-arg function. - UI button improvements.
bisgardo
reviewed
Jun 28, 2023
bisgardo
changed the title
|
Force merged because the workflow seems indefinitely queued. Tests pass locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract WalletConnect listeners from
AccountCoordinatorto newWalletConnectCoordinatorand ensure that it's initialized only once. This ensures that events are handled only once and thus that views are pushed only ones.Add decoding for supported
WalletConnectpayloads, bridge code for invokingparameter_to_json_inputin crypto lib, and support for contract update in transaction builder and storage object.Implement request approval/reject logic and add corresponding views.
Extract account from session data - this isn't reliable enough as it enables use of unexpected account from old session! This includes checks that the only the "ccd" namespace with only a single account (which exists) is provided/defined. We should also check that it has the expected methods and events. If the checks fail we report an error in the app but doesn't actually reject the request. This will be added afterwards.
Improve debug view from QR scanner.
CI: Use fixed Xcode version
showMainTabbar: Only reinitialiseAccountsCoordinatorif one isn't already running - is that still relevant given that we explicitly nil it?