Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffrentiate chains in WalletConnect #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milsawicki
Copy link
Contributor

No description provided.

@milsawicki milsawicki changed the title Diffrentiate chains in walletConnect Diffrentiate chains in WalletConnect Jul 6, 2023
@milsawicki milsawicki requested a review from bisgardo July 6, 2023 12:57
@bisgardo
Copy link
Contributor

bisgardo commented Jul 7, 2023

Alternative (simpler) solution which also ensures that QR scanner is dismissed on proposal errors: #339.

bisgardo added a commit that referenced this pull request Jul 7, 2023
On proposal, expect `chains` value `ccd:testnet` or `ccd:mainnet`
depending on the network the app is built for.

This change also ensures that the QR code scanner is dismissed on
proposal error.

Alternative to
#337.
@bisgardo
Copy link
Contributor

bisgardo commented Jul 7, 2023

To be rebased and address the global constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants