Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Rosetta needs #21

Merged
merged 7 commits into from
May 17, 2022
Merged

Updates for Rosetta needs #21

merged 7 commits into from
May 17, 2022

Conversation

bisgardo
Copy link
Contributor

@bisgardo bisgardo commented May 16, 2022 •
edited

Purpose

Ensure that the SDK satisfy the needs of Rosetta.

Changes

  • Derive Display on AmountFraction.
  • Add comment to explain how to determine delegation pool of account referenced in PaydayAccountReward.
  • Fix deserialization of RewardsDataRaw.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@bisgardo bisgardo requested review from abizjak, shjortConcordium and td202 and removed request for abizjak and shjortConcordium May 17, 2022 12:30
abizjak
abizjak reviewed May 17, 2022
View reviewed changes
src/types/mod.rs Outdated Show resolved Hide resolved
bisgardo
bisgardo commented May 17, 2022
View reviewed changes
src/types/mod.rs Outdated Show resolved Hide resolved
@bisgardo bisgardo mentioned this pull request May 17, 2022
Merged
@concordium-github concordium-github marked this pull request as ready for review May 17, 2022 21:39
@bisgardo bisgardo merged commit 2594d63 into main May 17, 2022
@bisgardo bisgardo deleted the rosetta branch May 17, 2022 21:43
@bisgardo bisgardo mentioned this pull request Jun 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@td202 td202 td202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bisgardo @abizjak @td202 @concordium-github