Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate types and reexport from concordium-contracts-common #28

Merged
merged 8 commits into from
Aug 12, 2022
Merged

Remove duplicate types and reexport from concordium-contracts-common #28

merged 8 commits into from
Aug 12, 2022

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Aug 5, 2022 •
edited
Loading

Purpose

Take advantage of types from concordium-contracts-common.
Related to Concordium/concordium-base#180.

Changes

  • Update concordium-base submodule.
  • Remove concordium-contracts-common as a direct submodule and instead use it through the concordium-base submodule.
  • Remove ReceiveName and InitName in favor of OwnedReceiveName and OwnedContractName.
  • Remove ContractAddress and Address in favor of the ones in concordium-contracts-common.
  • Fix examples with the recent changes.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh mentioned this pull request Aug 5, 2022
Closed
@limemloh limemloh force-pushed the unify-common-types branch 2 times, most recently from 581f77e to 3adf69c Compare August 8, 2022 09:22
@limemloh limemloh marked this pull request as ready for review August 8, 2022 11:55
@limemloh limemloh changed the title Unify common types Remove duplicate types and reexport from concordium-contracts-common Aug 8, 2022
@limemloh limemloh force-pushed the unify-common-types branch 4 times, most recently from 5c61352 to aaacb24 Compare August 8, 2022 13:17
abizjak
abizjak approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@abizjak abizjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always like it when there are more lines removed than added :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@limemloh limemloh force-pushed the unify-common-types branch 3 times, most recently from 1e11363 to b721fd6 Compare August 9, 2022 09:21
@limemloh limemloh force-pushed the unify-common-types branch 2 times, most recently from 437dd69 to d434a50 Compare August 9, 2022 09:53
@Bargsteen Bargsteen self-requested a review August 9, 2022 11:12
Bargsteen
Bargsteen approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@Bargsteen Bargsteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@abizjak abizjak merged commit b218b25 into main Aug 12, 2022
@abizjak abizjak deleted the unify-common-types branch August 12, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bargsteen Bargsteen Bargsteen approved these changes

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@limemloh @abizjak @Bargsteen