-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate types and reexport from concordium-contracts-common #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87c6fab
to
e59e497
Compare
581f77e
to
3adf69c
Compare
3adf69c
to
67401a0
Compare
5c61352
to
aaacb24
Compare
aaacb24
to
7121ba3
Compare
abizjak
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always like it when there are more lines removed than added :)
1e11363
to
b721fd6
Compare
437dd69
to
d434a50
Compare
Bargsteen
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
d434a50
to
9df9581
Compare
9df9581
to
df63a63
Compare
abizjak
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Take advantage of types from
concordium-contracts-common
.Related to Concordium/concordium-base#180.
Changes
concordium-base
submodule.concordium-contracts-common
as a direct submodule and instead use it through theconcordium-base
submodule.ReceiveName
andInitName
in favor ofOwnedReceiveName
andOwnedContractName
.ContractAddress
andAddress
in favor of the ones inconcordium-contracts-common
.Checklist
hard-to-understand areas.