Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deriving Reject for enums with fields #145

Merged
merged 9 commits into from
Aug 15, 2022

Conversation

Bargsteen
Copy link
Contributor

@Bargsteen Bargsteen commented Jul 22, 2022

Purpose

Addresses a primary part of #78 by allowing the user to derive Reject for enums with fields (if the fields implement Serial).
We will likely also need to update some tools and documentation in order for this task to be finished entirely.

Changes

  • Add the ability to derive Reject for enums with fields (if the enum implements Serial).

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Collaborator

@limemloh limemloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only a suggestion for an improvement

concordium-std-derive/src/lib.rs Outdated Show resolved Hide resolved
concordium-std-derive/src/lib.rs Outdated Show resolved Hide resolved
@limemloh limemloh mentioned this pull request Jul 28, 2022
13 tasks
concordium-std-derive/src/lib.rs Outdated Show resolved Hide resolved
concordium-std-derive/src/lib.rs Outdated Show resolved Hide resolved
concordium-std-derive/src/lib.rs Outdated Show resolved Hide resolved
@Bargsteen Bargsteen requested a review from abizjak August 8, 2022 08:20
concordium-std-derive/CHANGELOG.md Outdated Show resolved Hide resolved
@Bargsteen Bargsteen merged commit 06608b4 into main Aug 15, 2022
@Bargsteen Bargsteen deleted the kb/derive-reject-with-rv branch August 15, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants