SR: Encoder and decoder #1096
Merged
SR: Encoder and decoder #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lovromazgon
force-pushed
the
lovro/sr-encoder-decoder
branch
from
43feb98
to
71b30fe
Compare
hariso
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is based on top of #1051 and #1083, only the last 2 commits are relevant. Diff will look better once those PRs are merged and this branch is rebased.Rebased ✅This PR adds a schema registry
EncoderandDecoder. Currently the only format they support is Avro. These two objects tie together the client from #1048 and the Avro functionality in #1051.The
Encoderexposes two strategies:ExtractAndUploadSchemaStrategyextracts the schema from the structured data and uploads it to the schema registryDownloadSchemaStrategyalways downloads the schema from the schema registry (of course with caching)There are 2 TODOs left, one is a noop until we add support for protobuf, the other is a matter of priority and is captured in #1095.
Fixes #1042 and #1043
Quick checks: