SR: Extract Avro schema with reflection #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Jun 14, 2023
hariso
reviewed
Jun 26, 2023
- add map union resolver - add traversal functions - document code - improve tests
hariso
reviewed
Jul 12, 2023
hariso
reviewed
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function that traverses a struct (normally structured data) and produces an Avro schema from it. A good chunk of the code was taken from the SDK. Next time we add a format it would be advisable to extract the common code.
This approach still contains the drawback that it could produce a different schema if the provided value contains a
nilvalue (we have no type info in that case).Fixes #1041
Quick checks: