fix(core): socket pushes not working #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The io object seems weird in its behaviour, but the changes should allow for connected sockets to receive the data correctly
|
Proper testing is needed, I'm still facing network issues. |
* fix(router,admin): Admin Swagger using User headers * fix(router,admin): Admin Swagger routes not prefixed by '/admin' * chore(admin): Bearer prefix for admin Authentication header
refactor(grpc-sdk): remove sleep functions and add utility sleep function refactor(grpc-sdk): modify router async functions for consistency refactor(grpc-sdk): remove sleep functions and add utility sleep function refactor(grpc-sdk): modify router async functions for consistency refactor(chat): change router usage to routing manager fix(grpc-sdk): socket usage in routing manager fix(chat): socket communication refactor(push-notifications): migrate to new router refactor(storage): migrate to new router refactor(forms): migrate to new router fix(grpc-sdk): routing manager would declare routes even when there weren't any fix(forms): unnecessary check for form existence fix(grpc-sdk): unparsed socket response data type fix(push-notifications): left over getter call refactor(database): use new route declaration methods fix(database): url params weren't being added to path refactor(grpc-sdk): moved RouterBuilder to separate file refactor(grpc-sdk): rename build to add in RouterBuilder add(grpc-sdk): proper build function in RouterBuilder refactor(grpc-sdk): changed RoutingManager get/put etc
* feat(containers); database env vars fix(containers): postgres * fix(containers): master key env var not passed to Core * fix(containers): pass DB_PORT to mongodb and postgres * fix(containers): Makefile start-database * fix(containers): fix MongoDB chore(containers): bump Conduit versiot to v0.12.3
fix(chat): socket routes chore(router): fix typo
kon14
reviewed
Mar 25, 2022
modules/chat/src/routes/routes.ts
Outdated
| @@ -299,7 +299,7 @@ export class ChatRoutes { | |||
|
|
|||
| async onMessage(call: ParsedSocketRequest): Promise<UnparsedSocketResponse> { | |||
| const { user } = call.request.context; | |||
| const [roomId, message] = call.request.params; | |||
| const { roomId, message } = call.request.params; | |||
There was a problem hiding this comment.
This should be [ roomId, message ]. Socket params are an array.
kon14
reviewed
Mar 25, 2022
modules/chat/src/routes/routes.ts
Outdated
| @@ -323,7 +323,7 @@ export class ChatRoutes { | |||
|
|
|||
| async onMessagesRead(call: ParsedSocketRequest): Promise<UnparsedSocketResponse> { | |||
| const { user } = call.request.context; | |||
| const [roomId] = call.request.params; | |||
| const { roomId } = call.request.params; | |||
kon14
requested changes
Mar 25, 2022
|
@kon14 slow down, I'm looking at these right now, I only resolved conflicts previously. Even without the resolution it wouldn't work there are multiple typing issues. |
fix(chat): param extraction for socket routes still not convinced this works
kon14
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The io object seems weird in its behaviour,
but the changes should allow for connected
sockets to receive the data correctly
What kind of change does this PR introduce? (check at least one)