feat(core,grpc-sdk): rework service discovery #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specified via SERVICE_MONITOR_INTERVAL_MS. Default: 30000ms
fix(core,grpc-sdk): core missing closeConnection() calls feat(core): service discovery reconnection envs Conduit Service Discovery: - Multi-instance services are not handled individually (talk to Load Balancer) - Services that are Online AND Serving are recovered on startup - Services that go Offline OR Non-Serving are instantly removed from the list of exposed services - Reconnection to recently removed services is attempted using exponential backoff SERVICE_RECONN_RETRIES (default: 5) SERVICE_RECONN_INIT_MS (default: 250ms)
chore(core): service discovery cleanup
kkopanidis
approved these changes
Oct 14, 2022
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks Conduit's service discovery.
Added (optional) environment variables:
SERVICE_MONITOR_INTERVAL_MS: Service discovery monitor interval in ms (default: 30000)SERVICE_RECONN_RETRIES: Reconnection attempts before removal of offline services (default: 5)SERVICE_RECONN_INIT_MS: Initial delay for linear backoff reconnection to offline services in ms (default: 250)Extremely short
SERVICE_MONITOR_INTERVAL_MSvalues are expected to fail, but are not currently prohibited.This PR also introduces previously missing
closeConnection()calls for removed modules inCore.Modules already handled this through
grpc-sdkinstead as, in their case, the latter is configured to receive and act upon service updates fromCore.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)