-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0.0: for CakePHP 4.x #41
Conversation
# Conflicts: # .gitignore # README.md # composer.json # src/Error/SentryErrorHandlerTrait.php # src/Plugin.php
… isolation, we do not need the testapp anymore
… Bugfixes have already been part of CakePHP 4.0.0
Updates for CakePHP 4
Re implements test-app in 3.x
Instead of the ErrorLogger::log() that the plugin has, cakephp's default ErrorLogger::log() will be called directly if php's error_handler called directly. To avoid this, done`Log::setConfig()`with plugin's config before call ErrorHandler::register()
Fix some trivial issues
If passed $level is int(method not exists `Severity::{$level}()`, Breadcrumb's construct can't work as $level is to be an unacceptable value. Therefore, change to normalize $severity first
Fix underutilized flows in Client::capture()
Fix phpdoc and cosmetic changes
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 17 17
===========================================
Files 4 4
Lines 54 54
===========================================
Hits 54 54 Continue to review full report at Codecov.
|
Update README.md
Fix package description
Added missing strict type declaration
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 17 17
===========================================
Files 4 4
Lines 54 54
===========================================
Hits 54 54 Continue to review full report at Codecov.
|
Only ErrorHandlerTrait had a prefix, so for consistency, removed the prefix "Sentry" like the other classes.
Rename error handler trait
This PR is a working branch in preparation for the release.
For specific changes, please see milestone:3.x.
(This milestone will be closed after the 3.x branch has been merged into the master)