Release 3.0.0: for CakePHP 4.x #41
Merged
+1,671
−2,764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .gitignore # README.md # composer.json # src/Error/SentryErrorHandlerTrait.php # src/Plugin.php
… isolation, we do not need the testapp anymore
… Bugfixes have already been part of CakePHP 4.0.0
Updates for CakePHP 4
Re implements test-app in 3.x
Instead of the ErrorLogger::log() that the plugin has, cakephp's default ErrorLogger::log() will be called directly if php's error_handler called directly. To avoid this, done`Log::setConfig()`with plugin's config before call ErrorHandler::register()
Fix some trivial issues
If passed $level is int(method not exists `Severity::{$level}()`,
Breadcrumb's construct can't work as $level is to be an unacceptable value.
Therefore, change to normalize $severity first
Fix underutilized flows in Client::capture()
Fix phpdoc and cosmetic changes
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 17 17
===========================================
Files 4 4
Lines 54 54
===========================================
Hits 54 54 Continue to review full report at Codecov.
|
Update README.md
Fix package description
Added missing strict type declaration
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 17 17
===========================================
Files 4 4
Lines 54 54
===========================================
Hits 54 54 Continue to review full report at Codecov.
|
Only ErrorHandlerTrait had a prefix, so for consistency, removed the prefix "Sentry" like the other classes.
Rename error handler trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a working branch in preparation for the release.
For specific changes, please see milestone:3.x.
(This milestone will be closed after the 3.x branch has been merged into the master)