Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI error in job for prefer-lowest packages #50

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

o0h
Copy link
Contributor

@o0h o0h commented Jul 23, 2020

To fix cron build failure like https://travis-ci.org/github/Connehito/cake-sentry/jobs/708657380

What happened

As a result of the last build, each package remains in the cache with a non-prefer-lowest mode of dependency resolution.
This caused a situation where the version of PHPUnit conflicts with the version of PHPUnit when doing a downgrade of CakePHP.
The failure of the Composer's command made CI build an error.

What I do

To do prefer-lowest dependency resolution first, so that CakePHP downgrade can be done

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #50 into 2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x      #50   +/-   ##
=========================================
  Coverage     89.18%   89.18%           
  Complexity       24       24           
=========================================
  Files             5        5           
  Lines            74       74           
=========================================
  Hits             66       66           
  Misses            8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a047b...07a7578. Read the comment docs.

@o0h o0h changed the title Update dependencies for prefer-lowest Fix CI error in job for prefer-lowest packages Jul 23, 2020
@o0h o0h marked this pull request as ready for review July 23, 2020 07:50
@o0h o0h merged commit ec54ed8 into Connehito:2.x Jul 23, 2020
@o0h o0h deleted the 2.x-fix-ci-cron branch July 23, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants