Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide C API #6

Open
nemequ opened this issue Mar 3, 2016 · 1 comment
Open

Provide C API #6

nemequ opened this issue Mar 3, 2016 · 1 comment

Comments

@nemequ
Copy link
Contributor

nemequ commented Mar 3, 2016

The existing headers are really close to C… I think they would actually be usable as C if the functions just had C linkage.

You also have a #pragma once and #ifdef-based guards, you could get rid of one… IIRC #pragma once requires C11 (though AFAIK all compilers support it), so it would be nice if you got rid of the #pragma once.

@ConorStokes
Copy link
Owner

I'll definitely add the C linkage. I designed the API to be usable from C,
but I hadn't added the linkage yet as I hadn't had a chance to test it yet.

Agreed that if one goes, it should be #pragma once.

On Fri, Mar 4, 2016 at 1:10 AM, Evan Nemerson notifications@github.com
wrote:

The existing headers are really close to C… I think they would actually
be usable as C if the functions just had C linkage.

You also have a #pragma once and #ifdef-based guards, you could get rid
of one… IIRC #pragma once requires C11 (though AFAIK all compilers
support it), so it would be nice if you got rid of the #pragma once.


Reply to this email directly or view it on GitHub
#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants