Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to count unique attested subjects #466

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

alainncls
Copy link
Collaborator

@alainncls alainncls commented Dec 11, 2023

What does this PR do?

  1. Adds a script to get all attestations and save all the subjects in files
  2. Adds a script to count unique subjects

Related ticket

Fixes #475

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Dec 11, 2023
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for resilient-starburst-d5d6d9 ready!

Name Link
🔨 Latest commit 7519f66
🔍 Latest deploy log https://app.netlify.com/sites/resilient-starburst-d5d6d9/deploys/657c5b380174e80008dc17d2
😎 Deploy Preview https://deploy-preview-466--resilient-starburst-d5d6d9.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e7288e) 93.63% compared to head (8e2dc90) 93.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #466   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          20       20           
  Lines         330      330           
  Branches       76       76           
=======================================
  Hits          309      309           
  Misses         10       10           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the feat/count-unique-subjects branch 2 times, most recently from 7f6f4fe to 8e2dc90 Compare December 14, 2023 08:44
@alainncls alainncls marked this pull request as ready for review December 15, 2023 16:40
@alainncls alainncls merged commit 082b63c into dev Dec 15, 2023
12 checks passed
@alainncls alainncls deleted the feat/count-unique-subjects branch December 15, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want to count unique attested subjects
3 participants