-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: As a user, I want to be able to see the search results on Explorer #468
Conversation
✅ Deploy Preview for resilient-starburst-d5d6d9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
explorer/src/pages/Search/components/SearchAttestations/index.tsx
Outdated
Show resolved
Hide resolved
Also, check out to searching the "https://linea.easscan.org/schema/view" string for example, something is broken |
explorer/src/components/NavigationList/components/ListItemWithSubmenu/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #468 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 20 20
Lines 330 330
Branches 76 76
=======================================
Hits 309 309
Misses 10 10
Partials 11 11 ☔ View full report in Codecov by Sentry. |
The main problem your facing is g flag in regexp. Return the previous solution with RegExp and just change this:
Really weird issue, you can read there https://stackoverflow.com/a/30310596. The next problem - is overusing parseSearch function and other components. We should do the logic much simpler in Search component and don't try to divide it between SearchAttestations, SearchSchemas and SearchModules almost duplicating that. The parseSearch function will works good at Search and can pass the needed params in modules instead of x3 times triggering in each component. By removing this logic from that modules the reason question is to keep the loading inside the modules or just create separate files\file that will return ready-to-use swr hooks that can be easily used in Search component. (or at least loadAttestationList, loadModuleList, loadSchemaList but seems that we can do hook). |
What does this PR do?
#413