Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the type of the date fields in Attestation at the SDK level #472

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Converts the dates fields back to number (instead of default string)

Related ticket

Fixes #447

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for resilient-starburst-d5d6d9 ready!

Name Link
🔨 Latest commit 594f6ac
🔍 Latest deploy log https://app.netlify.com/sites/resilient-starburst-d5d6d9/deploys/657adcdbb3512100080f012b
😎 Deploy Preview https://deploy-preview-472--resilient-starburst-d5d6d9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e7288e) 93.63% compared to head (594f6ac) 93.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #472   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          20       20           
  Lines         330      330           
  Branches       76       76           
=======================================
  Hits          309      309           
  Misses         10       10           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls merged commit 24f3a1b into dev Dec 14, 2023
12 checks passed
@alainncls alainncls deleted the fix/fix-the-type-of-the-date-fields-in-attestation-at-the-sdk-level branch December 14, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix the type of the date fields in Attestation at the SDK level
4 participants