chore: When the Explorer is deployed in production, remove the HashRouter
#502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainncls
requested review from
satyajeetkolhapure,
orbmis,
0xEillo,
ars9 and
Solniechniy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #502 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 20 20
Lines 330 330
Branches 76 76
=======================================
Hits 309 309
Misses 10 10
Partials 11 11 ☔ View full report in Codecov by Sentry. |
Solniechniy
approved these changes
Jan 5, 2024
alainncls
deleted the
chore/when-the-explorer-is-deployed-in-production-remove-the-hashrouter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switches the Explorer from
HashRoutertoBrowserRouterto have cleaner URLsRelated ticket
Fixes #464
Type of change
Check list