Implement linea_setExtraData #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
fab-10
force-pushed
the
linea_setExtraData
branch
from
91c822a
to
9724f43
Compare
matkt
reviewed
Jun 20, 2024
arithmetization/src/main/java/net/consensys/linea/extradata/LineaExtraDataHandler.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/extradata/LineaExtraDataHandler.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/extradata/LineaExtraDataPlugin.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaSetExtraData.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaSetExtraData.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Filter94
reviewed
Jun 21, 2024
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaSetExtraData.java
Outdated
Show resolved
Hide resolved
Filter94
reviewed
Jun 21, 2024
acceptance-tests/src/test/java/linea/plugin/acc/test/rpc/linea/SetExtraDataTest.java
Outdated
Show resolved
Hide resolved
Filter94
reviewed
Jun 21, 2024
acceptance-tests/src/test/java/linea/plugin/acc/test/rpc/linea/SetExtraDataTest.java
Outdated
Show resolved
Hide resolved
Filter94
reviewed
Jun 21, 2024
arithmetization/src/main/java/net/consensys/linea/extradata/LineaExtraDataPlugin.java
Outdated
Show resolved
Hide resolved
Filter94
approved these changes
Jun 21, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
# Conflicts: # sequencer/src/main/java/net/consensys/linea/extradata/LineaExtraDataException.java # sequencer/src/main/java/net/consensys/linea/rpc/LineaSetExtraData.java # sequencer/src/test/resources/log4j2.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/Consensys/protocol-misc/issues/939
there is still a possible edge case that could arise when all the existing txs in the pool have an effective gas price lower than the minGasPrice, thus they are all in the Ready layer and not Prioritized, since the txpool promotions only happens during block import, no new blocks will be produced until a new right price tx is added to the pool.