Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ethclient and abigen to support privateFor #112

Closed
stevenroose opened this issue May 5, 2017 · 7 comments
Closed

Upgrade ethclient and abigen to support privateFor #112

stevenroose opened this issue May 5, 2017 · 7 comments

Comments

@stevenroose
Copy link
Contributor

stevenroose commented May 5, 2017

Currently the privateFor parameters is supported by the JSON-RPC API. The Go bindings in ethclient and abigen (that uses ethclient under the hood) do not yet.

Depends on: #90

@stevenroose
Copy link
Contributor Author

I'm looking into how hard it is to do.

@stevenroose
Copy link
Contributor Author

Back then, I realised it would be possible once #90 was solved, since abigen primarily relies on sendRawTransaction. Anyone else trying to solve this?

@conor10
Copy link
Contributor

conor10 commented Jul 17, 2017

I'm planning to take a look at #90, unless any of you guys are already @patrickmn? I saw the help wanted label was removed.

@patrickmn
Copy link
Contributor

@conor10 Please feel free. I was going to, but haven't started.

@stevenroose
Copy link
Contributor Author

There's two parts of the problem. One is the server, which allowing the sendRawTransaction JSON-RPC call to have a privateFor field somewhere. The other is incorporating that in the ethclient package. The latter should be more straightforward, but makes no sense if the former is not yet done.

It's not easy to find how and where there were modifications to geth regarding private transactions. F.e. I can only see private.P.Send being called with the data field being contract code, not when making normal non-deployment transactions.

Let me open a WIP PR with what I got.

@patrickmn
Copy link
Contributor

Regarding modifications, see #146 (comment)

@prd-fox
Copy link
Contributor

prd-fox commented Oct 3, 2019

This has been implemented in #819

@prd-fox prd-fox closed this as completed Oct 3, 2019
jbhurat added a commit that referenced this issue Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants