-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ethclient and abigen to support privateFor #112
Comments
I'm looking into how hard it is to do. |
Back then, I realised it would be possible once #90 was solved, since abigen primarily relies on sendRawTransaction. Anyone else trying to solve this? |
I'm planning to take a look at #90, unless any of you guys are already @patrickmn? I saw the help wanted label was removed. |
@conor10 Please feel free. I was going to, but haven't started. |
There's two parts of the problem. One is the server, which allowing the sendRawTransaction JSON-RPC call to have a privateFor field somewhere. The other is incorporating that in the ethclient package. The latter should be more straightforward, but makes no sense if the former is not yet done. It's not easy to find how and where there were modifications to geth regarding private transactions. F.e. I can only see Let me open a WIP PR with what I got. |
Regarding modifications, see #146 (comment) |
This has been implemented in #819 |
Currently the
privateFor
parameters is supported by the JSON-RPC API. The Go bindings in ethclient and abigen (that uses ethclient under the hood) do not yet.Depends on: #90
The text was updated successfully, but these errors were encountered: